Skip to content

Render highlighted documents - #9049

Merged
hweihwang merged 1 commit into
review/structured-markdown-comparison-changesfrom
review/structured-markdown-comparison-documents
Sep 3, 2026
Merged

Render highlighted documents#9049
hweihwang merged 1 commit into
review/structured-markdown-comparison-changesfrom
review/structured-markdown-comparison-documents

Conversation

@hweihwang

@hweihwang hweihwang commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Part 3 of the version-comparison work for nextcloud/collectives#599: the Full documents view, so you can read both originals while seeing exactly what changed.

  • Both originals rendered read-only, highlighted at the reported positions; paired navigation, independent scrolling, expandable gaps
  • Three width-selected modes: wide, paired, and Before/After tabs on narrow screens
  • A bounded fallback: rendered comparison rejects input lines above 20,000 characters and the literal-source display stops at a safe boundary, so oversized documents degrade without blocking the page

Depends on: #9048 (base review/structured-markdown-comparison-changes). Followed by #9050.

Full story, screenshots and the test matrix live in the #599 implementation update: nextcloud/collectives#599 (comment)

AI disclosure: developed with OpenAI Codex (gpt-5.6-sol). Codex generated the implementation and tests under my direction; I reviewed, cleaned and verified the code, ran the full test and CI matrix, and signed the commits personally.

Assisted-by: OpenAI Codex:gpt-5.6-sol
Signed-off-by: Hoang Pham <hoangmaths96@gmail.com>
@hweihwang
hweihwang force-pushed the review/structured-markdown-comparison-documents branch from a85fb33 to a4186a9 Compare September 1, 2026 21:09
@hweihwang
hweihwang marked this pull request as ready for review September 1, 2026 21:24
@hweihwang
hweihwang requested review from benjaminfrueh and removed request for max-nextcloud, mejo- and silverkszlo September 1, 2026 21:34
@benjaminfrueh

Copy link
Copy Markdown
Contributor

/backport to stable35

@hweihwang
hweihwang merged commit 20dcd03 into main Sep 3, 2026
66 checks passed
@hweihwang
hweihwang deleted the review/structured-markdown-comparison-documents branch September 3, 2026 09:17
@backportbot

backportbot Bot commented Sep 3, 2026

Copy link
Copy Markdown

The backport to stable35 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable35
git pull origin stable35

# Create the new backport branch
git checkout -b backport/9049/stable35

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick a4186a90

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/9049/stable35

Error: Failed to check for changes with origin/stable35: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants